Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include file_name in PayloadHeader #231

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

SalmonSays
Copy link
Contributor

@SalmonSays SalmonSays commented Nov 3, 2024

This change fixes half of issue #141 by including the file_name in the PayloadHeader when sending files. This allows Files sent from Linux to Windows to retain their names/extensions.

SalmonSays and others added 2 commits November 4, 2024 15:15
This change fixes issue Martichou#141 by including the file_name in the PayloadHeader when sending files. This allows Files sent from Linux to Windows to retain their names/extensions.
@Martichou
Copy link
Owner

Hey! Thanks a lot for looking at that! :)

I've just made a small change as to not crash in case the file_name is None. As file_name is an Option, there's no point in unwraping the result. Other than that, thanks again!

@Martichou Martichou merged commit 59bc405 into Martichou:master Nov 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants