Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition with secrets edit command #193

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Fix race condition with secrets edit command #193

merged 3 commits into from
Jun 7, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jun 5, 2024 •
edited
Loading

Description

This PR addresses some minor changes to tests and fixes the race condition with editing secrets.

Issues Fixed

Tasks

  • 1. Remove any usage of agent unlock in beforeEach and use the PK_PASSWORD env instead.
  • 2. Fix race condition with the secrets edit command.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jun 5, 2024
@linear Linear
Copy link

linear bot commented Jun 5, 2024

ENG-152 `secrets edit` command race condtion

@tegefaulkes tegefaulkes force-pushed the feature-eng-152-secrets-edit-command-race-condtion branch from d3b4931 to 0deae29 Compare June 5, 2024 07:04
@tegefaulkes tegefaulkes merged commit 10c0ae3 into staging Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

secrets edit command race condtion
1 participant
@tegefaulkes