ability to select what attributes to return in Base find methods #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freibuis
reviewed
Aug 9, 2017
| @@ -1,4 +1,5 @@ | |||
| require File.expand_path("../lib/active_directory/version", __FILE__) | |||
| require 'date' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am populating select fields in html forms with users from active directory. The problem is that all I need is the dn, username and/or cn while the search method was returning all the attributes including group names and thumbnail data etc.
I changed the find methods to allow for the passing of an array of attributes for this purpose. The only portion that I think this might adversely effect is caching possibly with cases where caching occurs for a query with selected attributes and then you run a query for all attributes and it returns a cache with those missing but I haven't looked to much at that code. Let me know if it does and I'll make the required changes to caching to accommodate that.
Otherwise, if you want to pull, I can add the changes to the documentation.
Thanks, and great work with this by the way!