Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Dependency Update + NODE 20.x #181

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 11, 2023

MADiE PR

Jira Ticket: MAT-6310
(Optional) Related Tickets:

Summary

NPM Audit Fix and update Actions to Node 20.x

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@depfu depfu bot requested a review from a team as a code owner October 11, 2023 16:05
@depfu depfu bot added the depfu label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #181 (eba29d3) into develop (93e9a37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #181   +/-   ##
========================================
  Coverage    89.80%   89.80%           
========================================
  Files           11       11           
  Lines          304      304           
  Branches        54       54           
========================================
  Hits           273      273           
  Misses          26       26           
  Partials         5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sb-benohe sb-benohe changed the title 🚨 [security] Update twin.macro 2.8.2 → 3.4.0 (major) 🚨 [security] Update twin.macro 2.8.2 → 3.4.0 (major) + NODE 20.x Oct 11, 2023
@sb-benohe sb-benohe self-assigned this Oct 16, 2023
@sb-benohe sb-benohe changed the title 🚨 [security] Update twin.macro 2.8.2 → 3.4.0 (major) + NODE 20.x NPM Dependency Update + NODE 20.x Oct 18, 2023
@jkotanchik-SB jkotanchik-SB merged commit 0561d51 into develop Nov 14, 2023
7 checks passed
@depfu depfu bot deleted the depfu/update/develop/npm/twin.macro-3.4.0 branch November 14, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants