Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-8006: Fixed when alias is malformed .. or has spaces or whatever #405

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

gregory-akins
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-8006
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@gregory-akins gregory-akins requested a review from a team as a code owner December 9, 2024 18:45
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (4e0095b) to head (84a77fa).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #405   +/-   ##
========================================
  Coverage    87.75%   87.75%           
========================================
  Files           71       71           
  Lines         1829     1829           
  Branches       333      333           
========================================
  Hits          1605     1605           
  Misses         157      157           
  Partials        67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregory-akins gregory-akins merged commit 50ce7e4 into develop Dec 9, 2024
13 checks passed
@gregory-akins gregory-akins deleted the MAT-8006_FhirHelpersAlias branch December 9, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants