Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7791: Address feedback, add code coverage #406

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

mcmcphillips
Copy link
Contributor

@mcmcphillips mcmcphillips commented Dec 10, 2024

MADiE PR

Address feedback for MAT-7791
Jira Ticket: MAT-7791
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@mcmcphillips mcmcphillips requested a review from a team as a code owner December 10, 2024 18:56
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (0c6b6ed) to head (9c64438).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...nctionsSection/functionBuilder/FunctionBuilder.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    88.40%   89.54%   +1.14%     
===========================================
  Files           72       72              
  Lines         1855     1866      +11     
  Branches       334      337       +3     
===========================================
+ Hits          1640     1671      +31     
+ Misses         150      131      -19     
+ Partials        65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips mcmcphillips changed the title MAT-7791: partial MAT-7791: Address feedback, add code coverage Dec 10, 2024
@mcmcphillips mcmcphillips merged commit 9c93636 into develop Dec 11, 2024
12 of 13 checks passed
@mcmcphillips mcmcphillips deleted the MAT-7791-fix branch December 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants