Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mat 6138 remove hapi references #459

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Sep 19, 2023

MADiE PR

Jira Ticket: MAT-6138
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team September 19, 2023 20:08
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #459 (f4c1b93) into develop (2e66368) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    94.81%   94.88%   +0.07%     
===========================================
  Files           85       84       -1     
  Lines         2739     2719      -20     
  Branches       337      336       -1     
===========================================
- Hits          2597     2580      -17     
+ Misses          71       69       -2     
+ Partials        71       70       -1     
Files Changed Coverage Δ
...s/gov/madie/measure/config/FhirServicesConfig.java 100.00% <ø> (ø)
...gov/madie/measure/services/FhirServicesClient.java 76.47% <ø> (-4.18%) ⬇️
...cms/gov/madie/measure/services/VersionService.java 98.79% <100.00%> (+1.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmorasb nmorasb marked this pull request as ready for review September 20, 2023 13:00
@nmorasb nmorasb merged commit 46ff850 into develop Sep 20, 2023
5 checks passed
@nmorasb nmorasb deleted the feature/MAT-6138-remove-HAPI-references branch September 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants