Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat 6058 Refactor QICore & QDM Group validation #466

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

gregory-akins
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6058
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@gregory-akins gregory-akins requested a review from a team as a code owner September 28, 2023 18:05
adongare
adongare previously approved these changes Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #466 (0aa708e) into develop (4a72c5d) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage    94.96%   95.30%   +0.33%     
===========================================
  Files           85       88       +3     
  Lines         2759     2767       +8     
  Branches       341      340       -1     
===========================================
+ Hits          2620     2637      +17     
+ Misses          69       63       -6     
+ Partials        70       67       -3     
Files Coverage Δ
...a/cms/gov/madie/measure/services/GroupService.java 98.42% <100.00%> (+4.48%) ⬆️
.../madie/measure/services/ModelValidatorLocator.java 100.00% <100.00%> (ø)
.../gov/madie/measure/services/QdmModelValidator.java 100.00% <100.00%> (ø)
...v/madie/measure/services/QicoreModelValidator.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

adongare
adongare previously approved these changes Sep 28, 2023
nmorasb
nmorasb previously approved these changes Sep 28, 2023
@gregory-akins gregory-akins dismissed stale reviews from nmorasb and adongare via 0aa708e September 28, 2023 19:09
@gregory-akins gregory-akins merged commit 096bccf into develop Sep 28, 2023
5 checks passed
@gregory-akins gregory-akins deleted the MAT-6058_RefactorQdmValidation branch September 29, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants