Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6295 fix group population and stratification changes for QDM test… #488

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Oct 25, 2023

… cases

MADiE PR

Jira Ticket: MAT-6295
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner October 25, 2023 13:49
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #488 (a527438) into develop (664643b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    95.32%   95.36%   +0.03%     
===========================================
  Files           88       88              
  Lines         2781     2803      +22     
  Branches       341      347       +6     
===========================================
+ Hits          2651     2673      +22     
  Misses          63       63              
  Partials        67       67              
Files Coverage Δ
...a/cms/gov/madie/measure/services/GroupService.java 98.60% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sb-cecilialiu sb-cecilialiu merged commit d3a1428 into develop Oct 30, 2023
5 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-6295_qdmStratificationExpectedValues branch October 30, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants