Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6429 MAT-6428: change bar to newline during SDE and RAV concat #524

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Dec 8, 2023

MADiE PR

Jira Ticket: MAT-6429
(Optional) Related Tickets:
MAT-6428

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team December 8, 2023 16:31
@nmorasb nmorasb marked this pull request as ready for review December 8, 2023 16:33
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e7c48b) 94.15% compared to head (33ca187) 94.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #524   +/-   ##
========================================
  Coverage    94.15%   94.15%           
========================================
  Files           92       92           
  Lines         3215     3215           
  Branches       429      429           
========================================
  Hits          3027     3027           
  Misses          91       91           
  Partials        97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmorasb nmorasb merged commit 733a675 into develop Dec 8, 2023
8 checks passed
@nmorasb nmorasb deleted the feature/MAT-6429-bar-to-newline-SDEs-RAVs branch December 8, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants