Anim last frame and a bunch more #68
Conversation
My greatest contribution yet
There was a tiny non-clickable gap on the "More messages below" button. It's only present in the live embedded chat in Firefox though ¯\_(ツ)_/¯
|
I'm not sure if I can follow the meaning/consequences of that bug completely. If you think the fix is beneficial for us, I'd just keep it. Might merge later today if I do more emote work, otherwise after review. |
|
It doesn't really fix the bug, it rather shifts the behaviour to be more favorable towards sgg chat in winning the focus battle. I think the thing to consider is that someone with dgg chat open will always have sgg chat loaded, where that isn't the case in reverse. Yeah, I just changed my opinion to canning it Hhehhehe |
JoannesJ
force-pushed
the
anim-last-frame-pr
branch
2 times, most recently
from
76503d5 to
13c6c48
Compare
JoannesJ
force-pushed
the
anim-last-frame-pr
branch
from
13c6c48 to
39ff63e
Compare
|
(squash before merging please 🙏 ) |
JoannesJ
force-pushed
the
anim-last-frame-pr
branch
from
5755a22 to
8927075
Compare
|
What is the philosophy on the scope of commits here? Ready to go, btw 👍 |
|
Erm, looking at it now I realize the commits are actually well-scoped as-is. Scratch that squash 👍 |
I applied a meh fix for the focus stealing issue MemeLabs/Rustla2/issues/117
Far from perfect, but I consider it better than nothing.
This fix does guarantee that focus will be stolen from dgg chat instead.
@xDashh Just can it if you don't like that idea.