Feature/26 Expanded node move the styles to theme, allow changes from variant #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsinnema
requested changes
Aug 9, 2022
| const styles = { | ||
| root: { | ||
| textColor: { | ||
| color: '#4579EE', |
There was a problem hiding this comment.
@vidhya-metacell should go into the theme instead of "hardcoded" color in the object
There was a problem hiding this comment.
@zsinnema updated this one
There was a problem hiding this comment.
@zsinnema if nothing is pending, can this be merged?
zsinnema
approved these changes
Aug 12, 2022
| @@ -23,6 +23,8 @@ const vars = { | |||
| ...nodeRed, | |||
| ...nodeBlue, | |||
| ...nodeGray, | |||
| functionTextColor: '#4579EE', | |||
There was a problem hiding this comment.
@vidhya-metacell why not just only in the theme.ts like f.e.
Line 279 in 858a7eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
