-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mieru protocol (issue #1563) (2nd attempt) #1697
Conversation
Thanks for your contribution. I have some confusion here: since Conn has been initiated on the mihomo side, why does |
I read the source code of // A ContextDialer dials using a context.
type ContextDialer interface {
DialContext(ctx context.Context, network, address string) (net.Conn, error)
} Then perhaps we can set
Finally, the mux feature of mieru can be used normally without affecting |
Please correct me with the understanding:
|
Most of your understanding should be correct, here are some small objections:
|
Updated the PR based on previous feedback. If it looks good but you don't like a rc version, I can create a new mieru release. |
The current PR should be close to perfect.
As a complete PR, we still hope to have a dependency without an rc version number. After these two modifications are completed, they will be merged directly. |
done |
Please downgrade the It will force set go version to 1.21. We need to maintain go1.20 compatibility. The merge of this PR has been forcibly rolled back. Please open a new PR with this change, thanks. |
Working on it. |
This is the second attempt to add mieru to mihomo.
The new mieru version resolved comments from #1574 about dialer proxy, concrete
*net.TCPConn
and*net.UDPConn
types, and DNS resolver.I created https://github.com/enfein/mieru/tree/main/test/deploy/mihomo to validate the change. Testing result can be found in test.txt. Also other people are confirming features are working enfein/mieru#172.