Add release workflows #188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
add-release-workflows
branch
from
e3364f6
to
44ca351
Compare
|
It looks like the old deploy script is still present. Is that still needed? |
legobeat
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
LGTM; @rickycodes anything outstanding you see as blocker for this currently?
|
The deploy step is still missing from this workflow. Which isn't a complete blocker (some automation is better than none), but it should at least be called out in the instructions if it's to remain a manual step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bare minimum setup for automating npm releases in this repository.
I've tested this in my fork here:
https://github.com/rickycodes/test-dapp/actions/runs/2864216714