Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/station partionning #45

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Fix/station partionning #45

merged 13 commits into from
Jul 9, 2024

Conversation

louisPoulain
Copy link
Collaborator

No description provided.

louisPoulain and others added 5 commits June 11, 2024 15:24
Don't track tests json and logs
69125ce
More logging to track issue
ae593e6
Add small test
0aa1352
Add file to ignore
529f7cf
@louisPoulain
Change bit generator
0f09525 
This should fix the bug of having different partiotionning with the same seed on different computers. See #44
@louisPoulain louisPoulain linked an issue Jun 26, 2024 that may be closed by this pull request
Data partionning with same seed produces different partitions #44
Closed
@louisPoulain
Copy link
Collaborator Author

louisPoulain commented Jun 26, 2024 •
edited
Loading

We still need to try on our 2 systems @dnerini but looking at the documentation, we should be fine.

@louisPoulain
Copy link
Collaborator Author

louisPoulain commented Jul 1, 2024 •
edited by dnerini
Loading

As discussed, we need to coordinate to see whether this change is working.
Here are the station_wind_speed.json and the train_val_test.json. Can you join yours @dnerini or tell me if you get the same results (with seed 42 and the PCG64) ?

@louisPoulain
Copy link
Collaborator Author

At the moment, this PR requires a bit of testing as it does not seem to produce consistent results.

@louisPoulain
Copy link
Collaborator Author

@dnerini This PR is now ready for review too. My errors were due to a misuse of PCG64

@louisPoulain louisPoulain marked this pull request as ready for review July 8, 2024 09:01
@dnerini
Copy link
Member

dnerini commented Jul 9, 2024

As discussed, we need to coordinate to see whether this change is working. Here are the station_wind_speed.json and the train_val_test.json. Can you join yours @dnerini or tell me if you get the same results (with seed 42 and the PCG64) ? stations_wind_speed.json train_validation_test.json

@dnerini dnerini closed this Jul 9, 2024
@dnerini dnerini reopened this Jul 9, 2024
@dnerini dnerini merged commit cb56843 into main Jul 9, 2024
4 checks passed
@dnerini dnerini deleted the fix/station_partionning branch July 9, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnerini dnerini dnerini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data partionning with same seed produces different partitions
2 participants
@louisPoulain @dnerini