Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cloud cover probabilistic #52

Merged
merged 30 commits into from
Sep 6, 2024
Merged

Feature/cloud cover probabilistic #52

merged 30 commits into from
Sep 6, 2024

Conversation

louisPoulain
Copy link
Collaborator

Implements two new probabilistic layers for the cloud cover post-processing.

@louisPoulain louisPoulain requested a review from dnerini August 9, 2024 17:30
@louisPoulain louisPoulain marked this pull request as draft September 2, 2024 12:14
@louisPoulain louisPoulain marked this pull request as ready for review September 3, 2024 09:11
@louisPoulain louisPoulain requested review from dnerini and removed request for dnerini September 3, 2024 13:15
@louisPoulain louisPoulain marked this pull request as draft September 4, 2024 07:28
@louisPoulain louisPoulain marked this pull request as ready for review September 4, 2024 07:34
dnerini
dnerini reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! see below, we need to find a solution for this truncated vs censored distribution. For cloud cover, we typically work with a censored distribution, I guess

mlpp_lib/probabilistic_layers.py Outdated Show resolved Hide resolved
mlpp_lib/probabilistic_layers.py Outdated Show resolved Hide resolved
@louisPoulain louisPoulain marked this pull request as draft September 4, 2024 13:12
@dnerini dnerini marked this pull request as ready for review September 5, 2024 13:12
@dnerini dnerini merged commit a376a39 into main Sep 6, 2024
2 checks passed
@dnerini dnerini deleted the feature/cloud_cover_probabilistic branch September 6, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnerini dnerini dnerini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisPoulain @dnerini