Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN bug in validation #59

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix NaN bug in validation #59

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d991e1a
Change from checking for NaNs to checking non finite values (Inf, -In…
Oct 7, 2024
9d0bb26
Fix - Check for non finite
Oct 7, 2024
eece7c6
Remove debugging log
louisPoulain Oct 8, 2024
082a004
Remove comment for another PR
louisPoulain Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlpp_lib/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,9 @@ def drop_nans(self, group_size: int = 1):
x, y, w = self._get_copies()

event_axes = [self.dims.index(dim) for dim in self.dims if dim != "s"]
mask = da.any(da.isnan(da.from_array(x, name="x")), axis=event_axes)
mask = da.any(~da.isfinite(da.from_array(x, name="x")), axis=event_axes)
if y is not None:
mask = mask | da.any(da.isnan(da.from_array(y, name="y")), axis=event_axes)
mask = mask | da.any(~da.isfinite(da.from_array(y, name="y")), axis=event_axes)
mask = (~mask).compute()

# with grouped samples, nans have to be removed in blocks:
Expand Down
Loading