Implement a 3D sphere mode for the Markers module #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wide-Cat
requested changes
Jun 19, 2024
src/main/java/meteordevelopment/meteorclient/systems/modules/render/marker/Sphere3dMarker.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/render/marker/Sphere3dMarker.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds a 3D sphere as a possible marker.
Such a feature is useful for visualizing the spawn radius of various farms. Also looks cool.
Most of the code already existed in Sphere2DMarker, just modified it to render all layers at once, and optimized it a bit, as it has to do a lot more work to render the full sphere.
Slider caps the radius at 64 (making a diameter of 128, which is useful for most farms), but users can use the text input to make it larger if they really need to. Anything larger than 64 might cause frame drops (512 ran at 7fps for me).
How Has This Been Tested?
Checklist: