Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bcd link for cli upgrade #3768
base: main
Are you sure you want to change the base?
add bcd link for cli upgrade #3768
Changes from 3 commits
f56ba74
a4fad7b
20c5caf
977cde3
e3892de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion 1: [command-change](https://github.com/Azure/azure-cli-extensions/blob/main/src/command-change/README.md)
We should not be sending customers to GitHub from conceptual content unless it is for a sample. Can this be changed to a link to our autogenerated reference content?
Comment 2: I'm thinking about SEO. Can the
azure-cli-diff-site.azurewebsites.net
be given a H1 name? The only way for our customers to find this URL is through this one conceptual doc link?Suggestion 3: This information is very informative and I feel needs to be in
azure-docs-cli
published in the same node as our Breaking Changes doc --> [doc] (https://github.com/Azure/azure-cli/blob/897a4cd2874e315558d1f1925e866a80ab945f18/doc/breaking_change_detection_guidelines.md)Suggestion 4: Can we reword this paragraph to something along the lines of ...
"The Azure CLI also provides a reference command, [az command-change](link to ref content), and a website, azure-cli-diff-site, to help you examine changes between CLI versions. Use the version comparison list provided to prepare your scripts for a version update. See [Breaking change detection for the Azure CLI](link to new doc in azure-docs-cli) for more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbradish-microsoft, thanks for the good suggestions.
azurewebsites.net
is more like an internal site name.@dcaro, @Jacekey23 how about your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is misleading in the upcoming breaking change since the tools does not show content of future versions.
SEO is important, search is the primary way people discover content nowdays.