Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] New sales design #210

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[core] New sales design #210

wants to merge 1 commit into from

Conversation

manolisliolios
Copy link
Collaborator

'

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 17518a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 0:58am

leecchh
leecchh reviewed Nov 19, 2024
View reviewed changes
packages/suins/sources/sales/pricing_config.move
public struct PricingConfig has copy, store, drop {
pricing: VecMap<Range, u64>,
}
public struct PricingConfig has store, drop { pricing: VecMap<Range, u64> }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would copy be useful in allowing user to check the current config? And add a pub read fun. If this won't be changed often and will be displayed in docs, then not needed

@manolisliolios manolisliolios changed the base branch from tlee/new-pricing to main November 29, 2024 12:58
@manolisliolios manolisliolios changed the title WIP [core] New sales design / new pricing config Dec 2, 2024
@manolisliolios manolisliolios changed the title [core] New sales design / new pricing config [core] New sales design Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecchh leecchh leecchh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manolisliolios @leecchh