[core] Config V2 & deprecate unused code #218
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -15,7 +15,7 @@ | |||
| /// useful for system-level discounts, or user-specific discounts. | |||
| /// | |||
| /// TODO: Consider re-using `RequestData` inside the `Receipt`. | |||
| /// TODO: Add settings for max year of renewals / max duration of registration here? | |||
| /// TODO: Add settings for max year of renewals / max duration of registration here? | |||
There was a problem hiding this comment.
I like this but let's include in a separate PR
manolisliolios
changed the title
| public_key: vector<u8>, | ||
| /// Minimum length of the label part of the domain. This is different from | ||
| /// the base `domain` checks. This is our minimum acceptable length (for sales). | ||
| /// TODO: Shoudl we consider removing this? Our range is [1,63] by design, and |
There was a problem hiding this comment.
We can keep this as backup or in case we redesign in the future
I did a minor restructure of the codebase to deprecate what's not needed.
That (for now) includes:
update_image.move: We have proceeded with a different design overall.config.move: I created aCoreConfigwhich is more flexible for future updates, and covers all our current needs. (please seetodopoint for discussion).auction.move: I kept the auction codebase (and actually ported it to our new config), but decided to move it to the deprecated folder to remove confusion. This system is no longer usable.Additional changes:
payments_versionin the configuration: This allows us to preventPaymentIntentfrom being finalized if it does not match the "configured" version from admin.Follow-ups:
I also wanna re-write
controller.moveto do whateverdirect_setuppackage does. There's no reason for us not to offer the basic functionality from our core package, now that we know that the basics will (most likely) never change. We can always deauthorize it too so thats also good news 😄Tests fail because of
renewal, register and discount_housepackages. I leave them here on purpose to avoid merge conflicts down the path. Their rewrite is coming up too.