Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Revamp controller to be functional #221

Open
wants to merge 1 commit into
base: ml/new-payments-design
Choose a base branch
from

Conversation

manolisliolios
Copy link
Collaborator

@manolisliolios manolisliolios commented Dec 2, 2024

  • Revamping controller.move to be functional in the core package. Since it's there, and we have aligned on the core needs, it's just an overkill to rely on an external package for all of this (makes managing things too hard).
  • Removing utils package.
  • Allows "objects" to have default names (tests coming up soon)

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 49873b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 2:34pm

@manolisliolios manolisliolios changed the title Revamp controller in core pkg to be functional [core] Revamp controller to be functional Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants