fix: remove veda-config related steps #181
Conversation
|
@smohiudd @anayeaye thoughts on creating a new directory just to test these changes? I was also thinking of using |
Workflow StatusStarting workflow... View action run Collection Publication Status
|
|
I'm ok with creating a temporary test directory |
|
|
||
| jobs: | ||
| dataset-publication-and-configuration: | ||
| permissions: | ||
| pull-requests: write | ||
| contents: read | ||
| runs-on: ubuntu-latest | ||
| environment: staging |
There was a problem hiding this comment.
This is hardcoded for now to use the staging environment variable I defined in this github repo
.github/workflows/pr.yml
Outdated
| response=$(curl -X POST \ | ||
| ${{ vars.STAGING_COGNITO_DOMAIN }}/oauth2/token \ | ||
| -H "Content-Type: application/x-www-form-urlencoded" \ | ||
| -d "grant_type=client_credentials" \ | ||
| -d "client_id=${{ vars.STAGING_CLIENT_ID }}" \ | ||
| -d "client_secret=${{ secrets.STAGING_CLIENT_SECRET }}" | ||
| -d "client_secret=${{ vars.STAGING_CLIENT_SECRET }}" |
There was a problem hiding this comment.
Does this need to be stored in the environment secret?
There was a problem hiding this comment.
I think using a secret in this case would be appropriate.
botanical
changed the title
botanical
requested review from
smohiudd
and removed request for
anayeaye and
smohiudd
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| branches: ['main', 'feat/automated-staging-publish'] |
There was a problem hiding this comment.
| branches: ['main', 'feat/automated-staging-publish'] | |
| branches: ['main'] |
I can remove this later but I added it to prove that it can be triggered on pushes to a branch
|
The action originally looked at all changed files in the dataset directory. Can we look at only the added files so we're only triggering new. Looks like tj-actions can find added files as well: |
|
Closing this in place of this work #185 |
#180
Testing
I used a valid collection to test this workflow and I updated the trigger to trigger on any pushes to this current branch but can change that later 😅