Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle analysis/define datasets w/o collection summaries #786
Handle analysis/define datasets w/o collection summaries #786
Changes from 7 commits
8a9b3d0
961d551
470eb9c
c71c440
02dcaca
4a69b11
94c564b
6055bef
3e61fdf
b931042
312ee9d
f58d42a
156c0a5
6463ab5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 295 in app/scripts/components/analysis/define/index.tsx
GitHub Actions / lint
Check warning on line 336 in app/scripts/components/analysis/define/index.tsx
GitHub Actions / lint
Check warning on line 282 in app/scripts/components/analysis/results/chart-card.tsx
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the type useful, we seem to need a new type. The components like
chart-card
has to have timeseries data, so it doesn't seem to reflect is actual usage to typetimeseires
as an optional. (Also the data with summaries and wo summaries having the same type is confusing, like this line : https://github.com/NASA-IMPACT/veda-ui/pull/786/files#diff-73d60515e81c1007b36e13ea2886f3b4e1457746381934d40af7802e39841022R182)How about leaving the
TimeseriesDataResult
as it is, but makingTimeseriesDataWithMissingSummaries
(I just made the variable name up) and use this type explicitly for the data without summaries?More food for thought: when the data is missing summaries, we don't seem to need any attributes from the collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of being explicit but if we dont seem to need any attributes from the collection when summaries is missing from the data, then we can probably just use existing type
DatasetLayer
. Will make this change