forked from NOAA-EMC/fv3atm
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFS-dev PR#94 #122
Merged
Merged
UFS-dev PR#94 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FS on WCOSS2 (NOAA-EMC#746) * fix out-of-bounds write in module_diag_hailcast * only correct RWA_new where RWA_adiabat(k).ge.1.E-12 * module_diag_hailcast.F90: update comments; changes from @adams-selin
…#759) Add doxygen to the cmake build and add doxygen build to CI.
NOAA-EMC#757) doxygen changes for io/module_fv3_io_def.F90 and module_fv3_config.F90 --------- Co-authored-by: Jun Wang <[email protected]>
…rent (NOAA-EMC#743) * Modifications to replace numerous p2p transfers in fill_nested_grid_cpl by a single MPI_Bcast * Add reason for including ESMF in fv_control_init. Add code to cleanup structures associated with Bcast_comm * Get rid of unneeded mpp_sync_self * Use mpp_broadcast instead of MPI_Bcast at the request of NOAA-GFDL * Get rid of mpp pelist scoping calls in fill_nested_grid_cpl(). This depends on NOAA-GFDL/FMS#1246 to be functional. More efficient 'if' test in fill_nested_grid_cpl() * Bcast_comm and sending_proc variables not needed anymore * New member of the fv_atmos_type type called BcastMember allows more efficient determination of ranks involved in the mpp_broadcast call in fill_nested_grid_cpl routine * Port to FMS-2023.02
…e_netcdf.F90 (NOAA-EMC#762) Update documentation in module_write_internal_state.F90 and module_write_netcdf.F90 --------- Co-authored-by: Dusan Jovic <[email protected]>
* add gflux * add runoff and drain to land coupling * add exchange coefficents * add zvfun to land coupling * minor fix in GFS type definitions * update sfc_land * remove Sa_ua and Sa_va from couling fields * fix prefix of snow area fraction standard name * rename exchange fields to follow inst convention * "Supplementary physics updates for RRFS code freeze" * update ccpp/physics by merging NOAA-EMC#161 --------- Co-authored-by: Ufuk Turuncoglu <[email protected]> Co-authored-by: Haiqin.Li <[email protected]>
mkavulich
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once submodule is updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to NOAA-EMC#682
Also contains:
NOAA-EMC#746
NOAA-EMC#759
NOAA-EMC#757
NOAA-EMC#743
NOAA-EMC#762