Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward solver adapted for automatic differentiation. #124

Merged
merged 13 commits into from
Sep 15, 2024
Merged

Conversation

Ig-dolci
Copy link
Collaborator

@Ig-dolci Ig-dolci commented Sep 3, 2024

This PR seeks to update the acoustic forward and FWI code using the automated adjoint solver.

New tools:

  • Two-level parallelism: Mesh and source with firedrake.adjoint.EnsembleReducedFunctional
  • Enable checkpointing.

What is missing: a proper absorbing boundary condition.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (2f19564) to head (3ed4881).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
spyro/solvers/forward_ad.py 87.71% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   83.69%   83.86%   +0.16%     
==========================================
  Files          47       49       +2     
  Lines        3361     3439      +78     
==========================================
+ Hits         2813     2884      +71     
- Misses        548      555       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ig-dolci Ig-dolci marked this pull request as ready for review September 4, 2024 06:19
@Ig-dolci
Copy link
Collaborator Author

Ig-dolci commented Sep 4, 2024

Spyro needs to update the firedrake version to have the checkpointing test pass.

@Olender
Copy link
Collaborator

Olender commented Sep 6, 2024

Spyro needs to update the firedrake version to have the checkpointing test pass.

I can install the latest version on the runner. We're currently using the version from 2024-07-19. Please let me know which version we should target for this update.

@Ig-dolci
Copy link
Collaborator Author

Spyro needs to update the firedrake version to have the checkpointing test pass.

I can install the latest version on the runner. We're currently using the version from 2024-07-19. Please let me know which version we should target for this update.

The latest.

@Olender
Copy link
Collaborator

Olender commented Sep 11, 2024

Ok, I have already installed everything in the runner and changed the firedrake location in the .yml workflow file

@Olender Olender merged commit 42b3ad3 into main Sep 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants