Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clayton-Engquist boundary condition for acoustic wave #134

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

SouzaEM
Copy link
Collaborator

@SouzaEM SouzaEM commented Nov 7, 2024

No description provided.

@SouzaEM SouzaEM self-assigned this Nov 7, 2024
@SouzaEM SouzaEM linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (96a1aad) to head (625f5da).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...yro/solvers/acoustic_solver_construction_no_pml.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   84.31%   84.34%   +0.02%     
==========================================
  Files          58       59       +1     
  Lines        3902     3935      +33     
==========================================
+ Hits         3290     3319      +29     
- Misses        612      616       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouzaEM SouzaEM requested a review from Olender November 7, 2024 15:20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea having the default top be false

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure that if we use other meshing tools in the future, we always follow the numbering scheme used here (top=1, bottom=2, etc.). In the future, it may be helpful to add a check after loading the mesh to verify this consistency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this verification is also necessary for elastic waves, I will merge this pull request and open a new issue for making sure the numbering scheme is appropriate for the mesh.

@SouzaEM SouzaEM merged commit 437cf28 into main Nov 8, 2024
5 checks passed
@SouzaEM SouzaEM deleted the issue_0132_CE_acoustic branch November 8, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clayton-Engquist A1 boundary condition for acoustic wave
2 participants