-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check XML resource attributes #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good oot-side for this now.
This would be good to get in when possible so we can move forward with zeldaret/oot#811
fig02
approved these changes
May 26, 2021
NEstelami
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZAPD will now perform more runtime checks for the attributes of each declared resource in the XMLs.
ZArray
to extract multiples elements. It doesn't need to create a newZFile
anymore.ZResource
needs to register the valid attributes for each one of them.RegisterRequiredAttribute(attr)
: Defines a mandatory attribute. ZAPD will throw an exception if a required attribute is missing. It's value will be stored inrequiredAttributes
.RegisterOptionalAttribute(attr, defaultValue = "")
. Defines an optional attribute. EachZResource
must check if the attribute is declared or not. It's value will be stored inoptionalAttributes
.ZResource
ZResource
will register the required the following attributes automatically:Name
as required.ZArray
), then 'Name' isn't required.OutName
andOffset
as optional.Custom
as non-value.Width
andHeight
attributes ofZTexture
has only decimal digits, and throw an exception otherwise.Related PR: #18
This PR will need a few changes in the OoT repo, since some objects are "invalid".
I'll PR the needed changes soonPR 799.