woc #17
Closed
woc #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: SongLyric class change
| @@ -1,6 +1,6 @@ | |||
| #include "Tools.h" | |||
|
|
|||
| QString Tools::milsec2Time(quint64 milisec) { | |||
| QString Tools::milsec2Time(const quint64& milisec) { | |||
There was a problem hiding this comment.
it makes no sense to use const reference for number types.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| struct Tools | |||
| { | |||
| static QString milsec2Time(quint64 milisec); | |||
| static QString milsec2Time(const quint64& milisec); | |||
| break; | ||
| } | ||
| case PlayMode::Shuffle: { | ||
| // TODO | ||
| auto index = randomInt(0, model.count() - 1); |
There was a problem hiding this comment.
Actually, shuffle doesn't mean random in official clients.
But it's okey.
| @@ -39,6 +39,8 @@ class OutputDeviceViewModel : public QAbstractListModel { | |||
| signals: | |||
| void currentIndexChanged(); | |||
|
|
|||
| //TODO: listen to system audio output device change | |||
| } | ||
|
|
||
| PlayingSongViewModel::~PlayingSongViewModel() { | ||
| save(); | ||
| } | ||
|
|
||
| PlayingSongViewModel* PlayingSongViewModel::create(QQmlEngine*, QJSEngine*) { | ||
| return new PlayingSongViewModel(); | ||
| return getInstance(); |
There was a problem hiding this comment.
Call QQmlEngine::setObjectOwnership to set correct ownership, otherwise the object will be freed twice, causing crash when quitting the application.
| } | ||
|
|
||
| // remove extra metadata | ||
| std::regex metaDataRegex(R"(\[by:.*?\])", std::regex_constants::ECMAScript); |
There was a problem hiding this comment.
There may be more field names aside from by for lrc. How about them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
选做：歌词（丑，但能用