woc #19
Closed
woc #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serein207
reviewed
Feb 25, 2024
| @@ -4,7 +4,13 @@ | |||
| #include <QAudioOutput> | |||
|
|
|||
| MusicPlayer::MusicPlayer(QObject* parent) : QMediaPlayer(parent), audioOutput(new QAudioOutput(this)) { | |||
| // TODO: connect signals and slots | |||
| // TODO: connect signals and slots (initially completed) | |||
There was a problem hiding this comment.
Suggested change
| // TODO: connect signals and slots (initially completed) |
| @@ -13,7 +13,14 @@ PlayingSongViewModel::PlayingSongViewModel(QObject* parent) : QObject{parent}, p | |||
| &PlayingSongViewModel::playSong); | |||
| QObject::connect(NextUpViewModel::getInstance(), &NextUpViewModel::playingSongChanged, this, | |||
| &PlayingSongViewModel::setPlayingSong); | |||
| // TODO: connect signals and slots | |||
|
|
|||
| // TODO: connect signals and slots (initially completed) | |||
There was a problem hiding this comment.
Suggested change
| // TODO: connect signals and slots (initially completed) |
| }; | ||
|
|
||
| qint64 timeStamp = -1; | ||
| qint64 lyric_start_index = 0; |
There was a problem hiding this comment.
Suggested change
| qint64 lyric_start_index = 0; | |
| qint64 lyricStartIndex = 0; |
| QList<SongLyric> SongLyricList; | ||
|
|
||
| // get rid of jsons of the header | ||
| qint64 first_index = 0; |
There was a problem hiding this comment.
Suggested change
| qint64 first_index = 0; | |
| quint64 firstIndex = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
（很小声）只做了必做的内容