woc #22
Closed
woc #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,14 +192,23 @@ Song NextUpViewModel::getNextSong() { | |||
| } | |||
| case PlayMode::ListRepeat: { | |||
| // TODO | |||
| auto index = model.indexOf(song); | |||
| index++; | |||
| song = model[index]; | |||
There was a problem hiding this comment.
What if index == size - 1?
| break; | ||
| } | ||
| case PlayMode::Shuffle: { | ||
| // TODO | ||
| auto index = model.indexOf(song); | ||
| srand(QTime(0,0,0).secsTo(QTime::currentTime())); | ||
| auto random = rand() % model.count(); |
There was a problem hiding this comment.
In fact, using the modulus operator cannot obtain the uniform distribution.
Suggest using modern methods provided by C++ or Qt.
| @@ -28,6 +28,8 @@ class SongLyricViewModel : public QAbstractListModel { | |||
|
|
|||
| QHash<int, QByteArray> roleNames() const override; | |||
|
|
|||
| QList<SongLyric> ProcessLyric (QString); | |||
There was a problem hiding this comment.
Suggested change
| QList<SongLyric> ProcessLyric (QString); | |
| QList<SongLyric> ProcessLyric(QString); |
Follow our code style defined in clang-format.yaml, if there is no specific reason.
There was a problem hiding this comment.
use pass by const reference for large object if you don't expect to change it 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
无选做