Add third platform login and modify login flow #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes are made in the login. The main purpose is to standardize the uid or email that users use to log in, users can use both to log in, but the program will only store the uid as key.
This reverts commit a5bf4d5. it seems this commit override some changes from remote
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 8313204 | Generic High Entropy Secret | 13c06e6 | api/v1/oauth_client.go | View secret |
| 8313204 | Generic High Entropy Secret | d2f03eb | api/v1/oauth_client.go | View secret |
| 8313204 | Generic High Entropy Secret | a6639f2 | api/v1/oauth_client.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
See d2f03eb, the program only restore the user id as redis key. |
aimixsaka
pushed a commit
that referenced
this pull request
Jul 16, 2024
Add third platform login and modify login flow
aimixsaka
pushed a commit
that referenced
this pull request
Jul 16, 2024
Add third platform login and modify login flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lark & github oauth login and modify login flow.