Fix: 解决了错误码覆盖的问题 #72
Merged
Fix: 解决了错误码覆盖的问题 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
但是整体 的错误处理还是有些混乱，感觉可以试着规范下 比如只定义有意义（用户能看懂）的错误码，没意义的打个自定义的log就行？ 比如service层尽量不定义localError,而是打log，然后controlller层调用的时候只需要返回一个抽象层次更高的错误就行 但如果service层有localError的话就用handleError处理下
aimixsaka
pushed a commit
that referenced
this pull request
Jul 16, 2024
但是整体 的错误处理还是有些混乱，感觉可以试着规范下 比如只定义有意义（用户能看懂）的错误码，没意义的打个自定义的log就行？ 比如service层尽量不定义localError,而是打log，然后controlller层调用的时候只需要返回一个抽象层次更高的错误就行 但如果service层有localError的话就用handleError处理下
aimixsaka
pushed a commit
that referenced
this pull request
Jul 16, 2024
但是整体 的错误处理还是有些混乱，感觉可以试着规范下 比如只定义有意义（用户能看懂）的错误码，没意义的打个自定义的log就行？ 比如service层尽量不定义localError,而是打log，然后controlller层调用的时候只需要返回一个抽象层次更高的错误就行 但如果service层有localError的话就用handleError处理下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
但是整体 的错误处理还是有些混乱，感觉可以试着规范下
比如只定义有意义（用户能看懂）的错误码，没意义的打个自定义的log就行？
比如service层尽量不定义localError,而是打log，然后controlller层调用的时候只需要返回一个抽象层次更高的错误就行 但如果service层有localError的话就用handleError处理下
不过考虑到前端人员的对接，可以在开发时多返回些service层/util层的localError，然后在上线后逐步在controller层用更高层次的错误去取代