Python converter for NEXRAD BUFR DUMP #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraveenKumar-NOAA
requested review from
ShunLiu-NOAA,
delippi,
HuiLiu-NOAA,
TingLei-NOAA and
SamuelDegelia-NOAA
|
Thanks!
…On Fri, Nov 15, 2024 at 10:22 AM PraveenSingh-NOAA ***@***.***> wrote:
@PraveenKumar-NOAA <https://github.com/PraveenKumar-NOAA> requested your
review on: #225 <#225> Python
converter for NEXRAD BUFR DUMP.
—
Reply to this email directly, view it on GitHub
<#225 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOF252DBYQYBFA5LBITNLZ32AYUVNAVCNFSM6AAAAABR3T6A3GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGMYTKNJWHE4TINQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
SamuelDegelia-NOAA
previously approved these changes
Nov 19, 2024
|
@delippi @ShunLiu-NOAA please review this PR. |
| q.add('gateRange', '*/NL2RW{1}/DIST125M') | ||
| q.add('radialVelocity', '*/NL2RW{1}/DMVR') | ||
| q.add('spectralWidth', '*/NL2RW{1}/DVSW') | ||
| q.add('ppiVolume', '*/VOID') |
There was a problem hiding this comment.
Can we use volumeIndex and scanIndex for VOID and SCID?
There was a problem hiding this comment.
@ShunLiu-NOAA thanks, updated names as volumeIndex and scanIndex for VOID and SCID, respectively.
| q.add('volumeCoveragePattern', '*/VOCP') | ||
|
|
||
| # QualityMarker | ||
| q.add('windAlongRadialLineQM', '*/QCRW') |
There was a problem hiding this comment.
Can we use radialWindQM for QCRW?
There was a problem hiding this comment.
@ShunLiu-NOAA done!
There was a problem hiding this comment.
It looks like QCRW was changed to radialVelocityQM (consistent with the obs being called radialVelocity) instead of radialWindQM. Does this matter @ShunLiu-NOAA?
delippi
reviewed
Nov 25, 2024
|
@PraveenKumar-NOAA could you please fix this typo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Python converter for NEXRAD BUFR DUMP data.
The converter will be used to transform NEXRAD BUFR data into IODA (netCDF) format. Following steps similar to the GDASApp, a Python file and a JSON description file were created.
The following two files are new:
~/IODA/python/bufr2ioda_nexrad.py
~/IODA/python/bufr2ioda_nexrad.json
Related issue: #220
Validation for the output observation and IODA variable naming has been performed. A few variable names need to be discussed and will be adde to naming variable table.