Update UPP #774
Merged
Update UPP #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
|
Please fill out the PR template. Description, testing, dependencies. |
PR template updated with slides attached. |
zach1221
requested review from
SadeghTabas-NOAA,
jkbk2004 and
BrianCurtis-NOAA
DusanJovic-NOAA
approved these changes
Feb 6, 2024
SadeghTabas-NOAA
approved these changes
Feb 6, 2024
|
@jkbk2004 we need one additional approving review here. Can you please review this PR? |
jkbk2004
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
This PR will update UPP to the latest commit. With the updated UPP, this PR will fix the missing reflectivity bug when using NSSL MP, inline post and Cu together by adding nssl mp to microphysics options when assigning model reflectivity.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
#780
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
intel on Hera
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Yes. On Hera
Done.
See reflectivity before and after fix:
missing_refl_forPR.pptx
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
None.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs