Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynmix #37

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Dynmix #37

merged 11 commits into from
Jul 15, 2024

Conversation

malihass
Copy link
Collaborator

@malihass malihass commented Jul 11, 2024 •
edited
Loading

closes #35
closes #36

  • interface for dynamic mixers from list
  • interface for dynamics mixers specifically for loop reactor (break the block rectangular mesh into segment and set the mixer placement + normal dir based on the segment. Make sure to accommodate for rescaling)
  • fix tutorial cases for dynamic mixers

@malihass malihass merged commit baf3aaf into main Jul 15, 2024
7 checks passed
@malihass malihass deleted the dynmix branch July 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsitaram hsitaram Awaiting requested review from hsitaram

@mjrahimi mjrahimi Awaiting requested review from mjrahimi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic mixers placement loop reactor with dynamic mixers missing
1 participant
@malihass