Fixes to Scouts Loads Summary Measure

[mdahlhausen]

Pull request overview

• Fixes fix measure unit tests #11
• adds a debug mode to the measure with extra reporting to scout_loads_summary
• adds 'floating' as a state point to heating and cooling in os_lib_scout_meters.rb
• many changes to os_lib_heat_transfer.rb:
  • add hot water equipment to internal convective gain and internal radiant gain
  • remove other internal gain
  • add refrigeration gain
  • include air transfer
  • include reference for radiant delay factors
  • break gains into instantenous convective and radiant, for each load
  • add debug comparison to internal radiant gains calculation in EnergyPlus
  • add details on the solar radiation variables in comments
  • fixed issue where internal surface loads were getting reattributed back to those same surfaces, and instead allocate them to exterior surfaces in the space. The new method functionally assumes no interzone conduction.
  • discounts delayed solar gains, delayed internal gains, and internal surface convection from exterior surfaces

Pull Request Author

This pull request makes changes to (select all the apply):

• Reporting Measures

Author pull request checklist:

• Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
• Added tests for new measures
• Updated measure .xml(s)
• Register values added to comstock_column_definitions.csv
• Both options_lookup.tsv files updated
• 10k+ test run
• Change documentation written
• Measure documentation written
• ComStock documentation updated
• Changes reflected in example .yml files
• Changes reflected in README.md files
• Added 'See ComStock License' language to first two lines of each code file
• Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
• All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a code review on GitHub
• All related changes have been implemented: data and method additions, changes, tests
• If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• Reviewed change documentation
• Ensured code files contain License reference
• Results differences are reasonable
• Make sure the newly added measures has been added with tests and indexed properly
• CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

[eringold]

I think you need to update the DistrictHeating meter names to DistrictHeatingWater

[eringold]

@mdahlhausen I removed the tests from c.i. because 1) this isn't a workflow measure, 2) the tests are useful for debugging the measure but aren't doing any automated checks except for run completion, and 3) they take a long time and generate big output files.
Also I still see a number of failures, looks like mostly from simulation failures from bad meter specification:

Finished in 1743.899579s, 0.0115 runs/s, 1.0557 assertions/s.

  1) Failure:
ScoutLoadsSummary_Test#test_restaurant [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  2) Failure:
ScoutLoadsSummary_Test#test_district_cooling [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  3) Failure:
ScoutLoadsSummary_Test#test_scn [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  4) Failure:
ScoutLoadsSummary_Test#test_large_office_vav [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  5) Failure:
ScoutLoadsSummary_Test#test_large_office [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  6) Failure:
ScoutLoadsSummary_Test#test_small_office_high_loads [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  7) Failure:
ScoutLoadsSummary_Test#test_medium_office [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  8) Failure:
ScoutLoadsSummary_Test#test_doas_with_vrf [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

  9) Failure:
ScoutLoadsSummary_Test#test_research_special [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

 10) Failure:
ScoutLoadsSummary_Test#test_small_office [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

 11) Failure:
ScoutLoadsSummary_Test#test_district_heating [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

 12) Failure:
ScoutLoadsSummary_Test#test_mfm [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

 13) Failure:
ScoutLoadsSummary_Test#test_baseboard_electric [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

 14) Failure:
ScoutLoadsSummary_Test#test_secondary_school [C:/Repos/NREL/ComStock/measures/scout_loads_summary/tests/Measure_Test.rb:168]:
Expected: "Success"
  Actual: "Fail"

20 runs, 1841 assertions, 14 failures, 0 errors, 0 skips

Measure seems to still be a work in progress. Leaving open for now.