Fixes 'reload from csv' function, and a bug in plotting when measure … #256
+49
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name is truncated to end with space
wenyikuang
reviewed
Nov 21, 2024
| @@ -151,13 +151,14 @@ def __init__(self, s3_base_dir, comstock_run_name, comstock_run_version, comstoc | |||
| self.download_data() | |||
| pl.enable_string_cache() | |||
| if reload_from_csv: | |||
| upgrade_pqts = glob.glob(os.path.join(self.output_dir, 'ComStock wide upgrade*.parquet')) | |||
| upgrade_pqts = glob.glob(os.path.join(self.output_dir, 'cached_ComStock_wide_upgrade*.parquet')) | |||
There was a problem hiding this comment.
Yes, we should avoid using \\ in the whole file name...
wenyikuang
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name is truncated to end with space
Pull request overview
Postprocess measure plotting fails on some plots where folder name is truncated such that it ends with a space. Also, the feature to reload from csv was updated to reflect the new name regime
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csvoptions_lookup.tsvfiles updated.ymlfilesREADME.mdfilestest/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txtReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File