Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ANSI 301-2022: Boilers #1621

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

shorowit
Copy link
Contributor

Pull Request Description

Closes #1616.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Feb 21, 2024
@joseph-robertson
Copy link
Collaborator

Testing this branch here: NREL/resstock#1211.

Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NREL/resstock#1211 looks to be successful.

…o revert_ansi_301_2022_shared_boilers

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit shorowit merged commit c675adc into master Feb 22, 2024
7 checks passed
@shorowit shorowit deleted the revert_ansi_301_2022_shared_boilers branch February 22, 2024 19:53
@joseph-robertson joseph-robertson mentioned this pull request Feb 22, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildResidentialHPXML: add loop/coil watts for shared boiler
2 participants