-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electric panel #1853
Draft
joseph-robertson
wants to merge
126
commits into
master
Choose a base branch
from
electric_panel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Electric panel #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Oct 15, 2024
One issue that has come up is consistency between HPXML fields, e.g., storing HPWH voltage on |
joseph-robertson
commented
Dec 2, 2024
end | ||
end | ||
|
||
elsif type == HPXML::ElectricPanelLoadTypeWaterHeater |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these assignments to a table?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Support electric panel.
Related to: hpxmlwg/hpxml#420.
Checklist:
Watts
underPanelLoad
to something else;Power
?Capacity
? Decided onPowerRating
.electric_panel_xxx
arguments section maps more directly toElectricPanels
HPXML sectionbackup_heating_capacity
input for HPWH; assume no simultaneous operation and so takemax(heating_capacity, backup_heating_capacity)
? Can the 120V HPWH have backup?additional_properties.heat_rated_cops
,additional_properties.cool_rated_cops
)?HeatingSystem
,CoolingSystem
,HeatPump
: addheating_input_capacity
,cooling_input_capacity
, andbackup_heating_input_capacity
methods to hpxml.rbWaterHeatingSystem
: addheating_input_capacity
andbackup_heating_input_capacity
methods to hpxml.rb (additional_properties.cop
set byWaterheater.set_heat_pump_cop
)fan_watts_per_cfm
*xxx_airflow_cfm
?electric_auxiliary_energy / 2.08
?count
andfan_power
Checklist
Not all may apply:
EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run