F3/fix/hev exceeds max soc bug #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to not having assumed e-machine has efficiency curve that is symmetrical about zero power
```warning: unused import: `super::imports::*`
--> fastsim-core/src/air_properties.rs:1:5
|
1 | use super::imports::*;
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: constant `TOL` is never used
--> fastsim-core/src/vehicle/powertrain/fuel_converter.rs:5:7
|
5 | const TOL: f64 = 1e-3;
| ^^^
|
= note: `#[warn(dead_code)]` on by default
warning: `fastsim-core` (lib test) generated 2 warnings (run `cargo fix --lib -p fastsim-core --tests` to apply 1 suggestion)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s
Running unittests src/lib.rs (/Users/cbaker2/Documents/github/fastsim-3/target/debug/deps/fastsim_core-3d30028b72332929)
running 1 test
test simdrive::tests::test_sim_drive_hev ... FAILED
failures:
---- simdrive::tests::test_sim_drive_hev stdout ----
thread 'simdrive::tests::test_sim_drive_hev' panicked at fastsim-core/src/utils.rs:147:24:
index out of bounds: the len is 2 but the index is 2
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
simdrive::tests::test_sim_drive_hev
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 34 filtered out; finished in 0.02s
error: test failed, to rerun pass `--lib`
```
…xceeds-max-soc-bug # Conflicts: # fastsim-core/src/simdrive.rs # fastsim-core/src/traits.rs
# Conflicts: # fastsim-core/src/simdrive.rs # fastsim-core/src/traits.rs
…xceeds-max-soc # Conflicts: # fastsim-core/src/simdrive.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.