F3/generate variable paths #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # fastsim-core/Cargo.toml
…actice of direct set
TODO: investigate this!
tests still need to be fixed
TODO: get help from Robin in fixing this
calbaker
force-pushed
the
f3/generate-variable-paths
branch
from
303be44
to
af7d257
Compare
added polars as dependency
|
@robinsteuteville , please check if this does what you'd expect |
calbaker
commented
Aug 8, 2024
| import unittest | ||
| import fastsim as fsim | ||
|
|
||
| class TestParamPath(unittest.TestCase): |
There was a problem hiding this comment.
@robinsteuteville , please check if this test is doing what you'd expect.
removed deprecated test assets added test asset for demo file created useful environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #136 with more descriptive branch name
solves #345
TODO
dir()for traversing the hierarchytest_variable_pathsvariable_path_listoutput in demo_variable_paths.py matches the expected result stored in test assetssd.to_dataframe()or maybe even load the dataframe from file to comparewith_capacitymight eek out some better speedup for theSome(<some int>)case and theNonecase because it'd be pre-allocating a reasonable size or not pre-allocating at all, respectively -- no obvious speedup- [ ] see if speed ratio can be bumped back up to 8 and 3