Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to Test Uploading PyPI #161

Open
wants to merge 11 commits into
base: fastsim-2
Choose a base branch
from
Open

Add GitHub Action to Test Uploading PyPI #161

wants to merge 11 commits into from

Conversation

michael-okeefe
Copy link
Collaborator

@michael-okeefe michael-okeefe commented Oct 2, 2024 •
edited
Loading

This uses pieces from the workflow here to add a test push to testpypi to ensure a PyPI push will succeed before doing the real thing.

NOTE: for this to succeed, we will also need:

  • an account on testpypi (do we already have one with PyPI?)
  • the password for that account to be placed in the GitHub secrets section
  • test to confirm this works by manualling running release.yml and removing production PyPI
  • restore release.yml so that it will push to production PyPI
  • Rerun tests and remove draft status

@michael-okeefe michael-okeefe added the enhancement New feature or request label Oct 2, 2024
@michael-okeefe michael-okeefe self-assigned this Oct 2, 2024
@michael-okeefe michael-okeefe marked this pull request as draft October 16, 2024 23:13
michael-okeefe and others added 6 commits October 17, 2024 07:54
@michael-okeefe
Fix GitHub actions error in release.yaml
530ae24 
Got a deprecation error for using v2.* of download-artifact. Changed both upload and download to use v4. More details and the actual error appear below:

Error: This request has been automatically failed because it uses a deprecated version of `actions/download-artifact: v2.1.1`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
@michael-okeefe
Fixed typo on download-artifact version.
150216f 
It needs to be "@v4" instead of "@4"
Add example workflow f/ Python Packaging Guide
eb6ae93 
See:
https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
for details.
Temporarily rename project to testfastsim to test Test PyPI upload
f0d19e6
Restore name
ad8b324
Restore publishing to production PyPI
f9771fb
@michael-okeefe michael-okeefe marked this pull request as ready for review October 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbaker calbaker Awaiting requested review from calbaker

@kylecarow kylecarow Awaiting requested review from kylecarow

At least 1 approving review is required to merge this pull request.

Assignees

@michael-okeefe michael-okeefe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-okeefe