feat(system): Added new method to save the system to a given folder. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 96.02% 96.05% +0.02%
==========================================
Files 25 25
Lines 2166 2205 +39
==========================================
+ Hits 2080 2118 +38
- Misses 86 87 +1 ☔ View full report in Codecov by Sentry. |
daniel-thom
reviewed
May 1, 2024
List of changes: - Created a new method `.save` that saves all the content of the system (.json + time series) to a desired folder, - Save method can archive the folder to enable easy sharing of the system, - Added testing to validate that save in fact creates the folder and that when we zip it we delete that folder. Closes #10
and we do not overwrite an existing folder
|
@daniel-thom ready for re-review |
daniel-thom
reviewed
Jun 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…23) List of changes: - Created a new method `.save` that saves all the content of the system (.json + time series) to a desired folder, - Save method can archive the folder to enable easy sharing of the system, - Added testing to validate that save in fact creates the folder and that when we zip it we delete that folder. - Closed backup connection from `time_series_metadata` Closes #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
.savethat saves all the content of the system(.json + time series) to a desired folder,
system,
that when we zip it we delete that folder.
howtosection that explains the method.Closes #10