Apply ASHP upgrade only when there are ducts #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbffe1e003 Merge pull request #1466 from NREL/pandas-updates 80c9fcbf43 Merge pull request #1469 from NREL/better_warning_checks d0e8d048fe Better warning checks. 26d0f04be6 Wrap pandas read_csv method to handle new version. git-subtree-dir: resources/hpxml-measures git-subtree-split: bbffe1e00350b5fda0392439de2bbd83f807fe83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates for:
national_upgrades.ymltesting_upgrades.ymlAlso separates out all GitHub Actions artifact
comparisons/baseline/annual/*.htmlplots by category. File sizes are now much smaller; we can actually open the files and view the contents now.Uses
read_csvintroduced in NREL/OpenStudio-HPXML#1466.We're getting apparent non-deterministic differences in
test/base_results/baseline/timeseries/buildstockbatch.csvfrom run to run. I'm attempting to address this by making summing across groupX.parquet timeseries data deterministic: collecting all timeseries in a single dataframe first, then sorting, then doing the groupby sum.Checklist
Not all may apply:
Documentation has been updatedIf related to resstock-estimation, checklist includes data dictionary, source report, options_lookup.If changes to project_testing tsvs, checklist includes yml_precomputed, yml_precomputed_outdated, yml_precomputed_weightChangelog has been updatedopenstudio tasks.rb update_measureshas been run