Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove total PTC output from all models #1072

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

cpaulgilman
Copy link
Collaborator

Fixes #644

Remove cf_ptc_total from cashloan and common.

Ignoring legacy cmod_ippppa.

Ignoring legacy cmod_ippppa
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Oct 26, 2023
@cpaulgilman cpaulgilman self-assigned this Oct 26, 2023
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Is there a reason cmod_ippppa hasn't been moved to the attic? I don't think it needs to happen as a part of this PR, but it would be good to keep all of the code in ssc valid and move what we aren't keeping up to date.

@cpaulgilman
Copy link
Collaborator Author

Issue to move old IPP financial model code to attic: #1074

@cpaulgilman cpaulgilman merged commit f3672b5 into develop Oct 27, 2023
4 checks passed
@cpaulgilman cpaulgilman deleted the remove-cf_ptc_total branch October 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cf_ptc_total doesn't work
2 participants