Respect display order for sections and enforce mandatory questions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the section order to be set manually. It also has the advantage of enabling server-side control of survey logic (for example by enforcing mandatory questions).
…ry questions in the current section (optional parameter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the previous and next button helpers to respect the display order property of sections and allow server-side control of survey flow. I also wrote a new method to check whether all mandatory questions in a given section have been answered. This works correctly for labels, optional questions, etc. The last commit uses this method to add a configurable option which can prevent the user from moving to the next section before completing all mandatory questions in the current section.