Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/kobayashi/creatingstories file/teacher #879

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Ryotakobayash
Copy link
Collaborator

対応Issue

resolve #0

概要

Teacherページに関連したコンポーネントをStorybook上に表示させる。

画面スクリーンショット等

image

テスト項目

  • Storybook上に↑のスクリーンショットと同じようなストーリーが表示されるか
  • 全てのコンポーネントがエラーなく表示できているか

備考

@Ryotakobayash Ryotakobayash self-assigned this Oct 2, 2024
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作okでした!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

治し方いまいち分からなかったんですがdocs開いたときにモーダルの表示範囲が異様に小さくて見えないのがきになりました。
image

export default {
title: 'FinanSu/teacher/AddModal',
component: AddModal,
argTypes: {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
argTypes: {},
argTypes: {
setShowModal: {
control: 'boolean',
defaultValue: false,
},
},

booleanを切り替えできるようにしたいです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants