Ensure TopKEncoder has correct outputs when model is saved #1225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220
Goals ⚽
Ensure top-k encoder model outputs are correct when model is saved.
Implementation Details 🚧
Removing
output_names
in BaseModel.compile when we have a TopKOutput. This enables keras to figure out the output names correctly.We currently set the output name based on the name of the model output. However, the BruteForce TopKLayer outputs a 2-tuple of scores and ids. Setting
model.output_names
to["top_k_output"]
keras writes out the model with only one output with this name. The relevant part in the keras code (2.12) is hereBefore
After
Testing Details 🔍
Adds assertion for expected output signature in test of topk encoder