Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] Add utilities for processing ies light files #10

Open
wants to merge 2 commits into
base: pr/hdEmbree-distant-lights
Choose a base branch
from

Conversation

pmolodo
Copy link

@pmolodo pmolodo commented Jul 31, 2024

Description of Change(s)

Note: this change replaces this earlier version:

This adds ies.h and ies.cpp, for processing ies light files.

These are originally taken from blender, v4.1.1:

https://github.com/blender/blender/blob/v4.1.1/intern/cycles/util/ies.h
https://github.com/blender/blender/blob/v4.1.1/intern/cycles/util/ies.cpp
These files are provided by Blender under the Apache 2.0 license. (See the note here about how the "Blender Cycles rendering engine is available as Apache 2.0").

These are not yet built / used, but merely introduce the files for use in the codebase later (ie, as part of a reworked PixarAnimationStudios#2758).

NOTE: This chain of PRs was made separate from the PR documenting expected behavior:


  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@pmolodo pmolodo changed the title Add utilities for processing ies light files [hdEmbree] Add utilities for processing ies light files Jul 31, 2024
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from 214b5c8 to c90bbc4 Compare August 1, 2024 18:46
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from c3aa6e4 to 3525a4d Compare August 1, 2024 18:46
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 3525a4d to f31c62d Compare September 23, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from c90bbc4 to ab8259e Compare September 23, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from f31c62d to 36ddfe3 Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from ab8259e to 9212698 Compare October 21, 2024 17:06
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 36ddfe3 to 48bbdd2 Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from 9212698 to dc1a20b Compare October 22, 2024 18:11
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from 48bbdd2 to c3c1140 Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from dc1a20b to 8186d1d Compare October 23, 2024 17:29
@pmolodo pmolodo force-pushed the pr/hdEmbree-ies-cycles branch from c3c1140 to 8a6e0ce Compare October 23, 2024 18:19
@pmolodo pmolodo force-pushed the pr/hdEmbree-distant-lights branch from 8186d1d to d2840eb Compare October 23, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant